This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix the assignment of a delivery service to a server, to respect capabilities #7878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pabilities * adding changelog * fixing Traffic Portal to account for the correct field names * adding org server edge case
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7878 +/- ##
=============================================
- Coverage 65.64% 31.89% -33.75%
Complexity 98 98
=============================================
Files 323 719 +396
Lines 12836 82838 +70002
Branches 970 970
=============================================
+ Hits 8426 26424 +17998
- Misses 4050 54252 +50202
- Partials 360 2162 +1802
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zrhoffman
approved these changes
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of attempting to execute direct DS assignment in TP
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run Traffic Ops and Traffic Portal.
Create a deliveryservice and assign a topology to it.
Now, try to assign a server independently to this DS.
Make sure that it works.
Now try the above operations with and without required capabilities on the DS, and server capabilities on the server.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist