This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Reverting partial change from PR 7891. #7929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrhoffman
approved these changes
Jan 30, 2024
Member
zrhoffman
left a comment
There was a problem hiding this comment.
Thanks! Will approve when test pass.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7929 +/- ##
============================================
+ Coverage 29.09% 32.03% +2.93%
Complexity 98 98
============================================
Files 605 722 +117
Lines 77535 82912 +5377
Branches 90 970 +880
============================================
+ Hits 22558 26558 +4000
- Misses 52894 54204 +1310
- Partials 2083 2150 +67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rimashah25
added a commit
that referenced
this pull request
Jan 30, 2024
(cherry picked from commit dc9c375)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure read-only role can perform only GET requests.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist