Add NelmioCors by default #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this makes sense for most users Im all 👍 |
Member
|
I'm still unsure about that because I don't see why an API could not exists without CORS, it's not a "required" feature for the api to work (at least users should know that an API doesn't need to allow cross origin request to work). Anyway, if users are having a hard time doing |
Member
Author
|
@soyuka the goal of the pack is to have an "out of the box" solution handling most common cases. As |
Simperfit
approved these changes
Feb 9, 2018
fabpot
approved these changes
Feb 9, 2018
mauchede
approved these changes
Feb 9, 2018
meyerbaptiste
approved these changes
Feb 9, 2018
Contributor
|
Thank you @dunglas. |
Contributor
|
Released in 1.1.0 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people struggle to properly configure CORS handling when creating an API with Symfony 4. To solve this problem, this PR adds NelmioCors (that now has a dedicated Flex recipe) to the pack.
Thanks to the new Flex's unpack feature, adding an extra dependency in the pack isn't a big deal anymore, because the user can easily remove it if he wants to customize the installation.
Another advantage of this PR: it will reduce the gap between the standard API Platform distribution and
composer req api.