Fix #257 uppercase attribute names will stay uppercased #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeb7b7b to
b757664
Compare
| { | ||
| $testClass = new MyTestClass(); | ||
|
|
||
| $reflectionClassProphecy = $this->prophesize('ReflectionClass'); |
There was a problem hiding this comment.
Why not instantiating directly the ReflectionClass ?
There was a problem hiding this comment.
Duno, I used this as an example and I probably got lost trying to understand what should call whom. It's a bit hard to write this kind of tests when you're not familiar with the ApiBundle internals, in my opinion.
|
It looks good to me but 2.0 will use the new Symfony Property Info Component.
|
|
@dunglas the PropertyInfo component do not |
|
@soyuka can you reopen this PR against 1.0, rebase and squash your commits? |
5c20605 to
cdec1e6
Compare
|
This seems to be fixed in 1.0 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some unit test, please let me know if I did something "the wrong way".