Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix deprecation notices in 2.4 #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

Fix deprecation notices in 2.4 #2920

merged 1 commit into from
Jul 9, 2019

Conversation

meyerbaptiste
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2896
License MIT
Doc PR n/a

@meyerbaptiste meyerbaptiste force-pushed the fix_deprecation_notices_2.4 branch from 5848691 to 08a4ce3 Compare July 8, 2019 16:02
@dunglas dunglas merged commit b448e74 into api-platform:2.4 Jul 9, 2019
@dunglas
Copy link
Member

dunglas commented Jul 9, 2019

Thanks @meyerbaptiste

@meyerbaptiste meyerbaptiste deleted the fix_deprecation_notices_2.4 branch July 9, 2019 20:40
@dunglas dunglas mentioned this pull request Jul 9, 2019
Closed
@teohhanhui teohhanhui mentioned this pull request Jul 10, 2019
Merged
teohhanhui
teohhanhui reviewed Jul 15, 2019
View reviewed changes
src/EventListener/ExceptionListener.php

public function __construct($controller, LoggerInterface $logger = null, $debug = false, string $charset = null, $fileLinkFormat = null)
{
$this->exceptionListener = new BaseExceptionListener($controller, $logger, $debug, $charset, $fileLinkFormat);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meyerbaptiste In which case would the constructor have these arguments? I can't find anything in Symfony.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, looks like it was reverted: symfony/symfony#31868

So we don't need to handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teohhanhui teohhanhui teohhanhui left review comments

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meyerbaptiste @dunglas @teohhanhui