Introduce and use an ItemMetadataInterface
#409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s `ItemMetadata`
2b2044d to
f4f4b38
Compare
|
Well, it was done on purpose to not introduce an interface here: Metadata are value objects used only by the API. It's like the A VO should not have an interface IMO. It should be used as is. If someone need to add extra properties in its app, he sould introduce a its own VO (and he can easily embed our metadata by composition). |
ItemMetadataInterfaceItemMetadataInterface
|
Well, that's a fair answer, I don't have the use case ATM anyway 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM, the class
ItemMetadatais final but without any interface. This PR introduce anItemMetadataInterface.