Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add EmbeddedNormalizer #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

teohhanhui
Copy link
Contributor

Related: #166 #181

Not sure if this is still relevant since #375 was merged...

@teohhanhui
Copy link
Contributor Author

@dunglas Will rebase if this is still useful... Let me know if the use cases in those issues are already supported.

@dunglas
Copy link
Member

dunglas commented Feb 19, 2016

@teohhanhui it should work without the need for a new normalizer in master now thanks to #375. Can you try?

@teohhanhui
Copy link
Contributor Author

That's great! I'll try upgrading soon...

@dunglas
Copy link
Member

dunglas commented Feb 23, 2016

#422 fixes the last problem related to this PR (and it proves it works for dates, but it is a generic solution).

@sroze
Copy link
Contributor

sroze commented Feb 24, 2016

@teohhanhui can you try with master?

By the way, without tests, there's almost no chances that we merge this PR :)

@teohhanhui teohhanhui closed this Mar 8, 2016
@teohhanhui teohhanhui deleted the embedded_normalizer branch March 18, 2016 06:13
@teohhanhui
Copy link
Contributor Author

@dunglas @sroze It's still a problem when using Doctrine Embeddables. They should be able to be marked as @ApiResource (for the whole set of features that come with that).

Also, currently the normalization / denormalization chain of ItemNormalizer stops when a Doctrine Embeddable is encountered (because it's just treated as a normal object and handled by ObjectNormalizer). This might not be a problem if #528 is implemented (our current process is inherently flawed because it depends on an unbroken chain from the top).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants