-
-
Notifications
You must be signed in to change notification settings - Fork 965
feat(graphql): allow to disable the introspection query #5711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3e5f8a5
feat(graphql): allow to enable/disable the introspection query
epourail be8bc99
feat(graphql): allow to enable/disable the introspection query
epourail ad911b7
feat(graphql): allow to enable/disable the introspection query
epourail 0736529
fix tests
epourail adc879f
add unitary tests
epourail bfff3f3
fix php-cs-fixer
epourail d161ef8
fix
epourail 36b8672
fix
epourail b553aae
cleanup
epourail 541d0a9
fix unit tests
epourail 0cdc49f
fix php-cs-fixer
epourail a325b6c
remove unuseful tests
epourail 9880458
tests
epourail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix php-cs-fixer
- Loading branch information
commit bfff3f37665134a5d7d4c6fa0fa82d782295202d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,9 +14,9 @@ | |
| namespace ApiPlatform\Tests\GraphQl; | ||
|
|
||
| use ApiPlatform\GraphQl\Executor; | ||
| use PHPUnit\Framework\TestCase; | ||
| use GraphQL\Validator\DocumentValidator; | ||
| use GraphQL\Validator\Rules\DisableIntrospection; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| /** | ||
| * @author Alan Poulain <[email protected]> | ||
|
|
@@ -28,7 +28,6 @@ public function testEnableIntrospectionQuery(): void | |
| $executor = new Executor(true); | ||
|
|
||
| $expected = new DisableIntrospection(DisableIntrospection::ENABLED); | ||
|
|
||
| $this->assertIsObject($executor); | ||
| $this->assertEquals($expected, DocumentValidator::getRule('DisableIntrospection')); | ||
| } | ||
|
|
@@ -38,7 +37,6 @@ public function testDisableIntrospectionQuery(): void | |
| $executor = new Executor(false); | ||
|
|
||
| $expected = new DisableIntrospection(DisableIntrospection::DISABLED); | ||
|
|
||
| $this->assertIsObject($executor); | ||
| $this->assertEquals($expected, DocumentValidator::getRule('DisableIntrospection')); | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.