Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: perf regression with Symfony 6.3 #5721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 2 commits into from
Aug 4, 2023
Merged

fix: perf regression with Symfony 6.3 #5721

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7737066
fix: perf regression with Symfony 6.3
dunglas Aug 4, 2023
beff962
fix
dunglas Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: perf regression with Symfony 6.3
  • Loading branch information
@dunglas
dunglas committed Aug 4, 2023
commit 7737066dd79652ba27d0ab384c23aac8087d0eb0
5 changes: 4 additions & 1 deletion src/Serializer/AbstractItemNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ public function supportsNormalization(mixed $data, string $format = null, array

public function getSupportedTypes(?string $format): array
{
return ['*' => true];
return [
'object' => true,
'native-array' => true,
];
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/Hal/Serializer/ItemNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public function testSupportsNormalization(): void
$this->assertFalse($normalizer->supportsNormalization($dummy, 'xml'));
$this->assertFalse($normalizer->supportsNormalization($std, $normalizer::FORMAT));
$this->assertEmpty($normalizer->getSupportedTypes('xml'));
$this->assertSame(['*' => true], $normalizer->getSupportedTypes($normalizer::FORMAT));
$this->assertSame(['object' => true, 'native-array' => true], $normalizer->getSupportedTypes($normalizer::FORMAT));

if (!method_exists(Serializer::class, 'getSupportedTypes')) {
$this->assertTrue($normalizer->hasCacheableSupportsMethod());
Expand Down
2 changes: 1 addition & 1 deletion tests/Serializer/AbstractItemNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function testSupportNormalizationAndSupportDenormalization(): void
$this->assertTrue($normalizer->supportsDenormalization($dummy, Dummy::class));
$this->assertFalse($normalizer->supportsDenormalization($std, \stdClass::class));
$this->assertFalse($normalizer->supportsNormalization([]));
$this->assertSame(['*' => true], $normalizer->getSupportedTypes('any'));
$this->assertSame(['object' => true, 'native-array' => true], $normalizer->getSupportedTypes('any'));

if (!method_exists(Serializer::class, 'getSupportedTypes')) {
$this->assertTrue($normalizer->hasCacheableSupportsMethod());
Expand Down
2 changes: 1 addition & 1 deletion tests/Serializer/ItemNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public function testSupportNormalization(): void
$this->assertTrue($normalizer->supportsDenormalization($dummy, Dummy::class));
$this->assertTrue($normalizer->supportsDenormalization($dummy, Dummy::class));
$this->assertFalse($normalizer->supportsDenormalization($std, \stdClass::class));
$this->assertSame(['*' => true], $normalizer->getSupportedTypes('any'));
$this->assertSame(['object' => true, 'native-array' => true], $normalizer->getSupportedTypes('any'));

if (!method_exists(Serializer::class, 'getSupportedTypes')) {
$this->assertTrue($normalizer->hasCacheableSupportsMethod());
Expand Down