chore: apply a micro-optimization to explode() calls (#5690)

api-platform · Aerendir · Jan 22, 2023 · Jan 23, 2023 · Jan 24, 2023 · Jan 26, 2023
commit 370bd071ca95eec43f989d7921ee0feb543d74fe
diff --git a/src/Doctrine/Odm/Filter/RangeFilter.php b/src/Doctrine/Odm/Filter/RangeFilter.php
@@ -70,7 +70,7 @@ protected function addMatch(Builder $aggregationBuilder, string $field, string $
     {
         switch ($operator) {
             case self::PARAMETER_BETWEEN:
-                $rangeValue = explode('..', $value);
+                $rangeValue = explode('..', $value, 2);
 
                 $rangeValue = $this->normalizeBetweenValues($rangeValue);
                 if (null === $rangeValue) {

diff --git a/src/Doctrine/Orm/Filter/RangeFilter.php b/src/Doctrine/Orm/Filter/RangeFilter.php
@@ -75,7 +75,7 @@ protected function addWhere(QueryBuilder $queryBuilder, QueryNameGeneratorInterf
 
         switch ($operator) {
             case self::PARAMETER_BETWEEN:
-                $rangeValue = explode('..', $value);
+                $rangeValue = explode('..', $value, 2);
 
                 $rangeValue = $this->normalizeBetweenValues($rangeValue);
                 if (null === $rangeValue) {

diff --git a/src/Symfony/Routing/ApiLoader.php b/src/Symfony/Routing/ApiLoader.php
@@ -80,7 +80,7 @@ public function load(mixed $data, string $type = null): RouteCollection
                     }
 
                     if ($controller = $operation->getController()) {
-                        $controllerId = explode('::', $controller)[0];
+                        $controllerId = explode('::', $controller, 2)[0];
                         if (!$this->container->has($controllerId)) {
                             throw new RuntimeException(sprintf('Operation "%s" is defining an unknown service as controller "%s". Make sure it is properly registered in the dependency injection container.', $operationName, $controllerId));
                         }