fix(validation): normalize constraint violation list#5866
Merged
soyuka merged 1 commit intoOct 5, 2023
Conversation
7652bc3 to
4964807
Compare
83a38c3 to
e0001f9
Compare
e0001f9 to
4fc56cf
Compare
Member
Author
|
Thanks @vincentchalamon ! |
dannyvw
reviewed
Oct 6, 2023
| } | ||
| ], | ||
| "hydra:title": "An error occurred", | ||
| "hydra:description": "title: This value should not be null.", |
Contributor
There was a problem hiding this comment.
@soyuka I checked the new release but our tests still fail. This line should be test instead of title
Member
Author
There was a problem hiding this comment.
hmm right it's good inside violations though but indeed this isn't correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5845 (comment) good catch thanks @dannyvw !