fix(Serializer): defaultContext in ItemNormalizer #5920
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8934396 to
fa0172a
Compare
fa0172a to
762fb97
Compare
soyuka
reviewed
Oct 27, 2023
| @@ -45,7 +45,7 @@ final class ItemNormalizer extends AbstractItemNormalizer | |||
|
|
|||
| public const FORMAT = 'jsonld'; | |||
|
|
|||
| public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, IriConverterInterface $iriConverter, ResourceClassResolverInterface $resourceClassResolver, private readonly ContextBuilderInterface $contextBuilder, PropertyAccessorInterface $propertyAccessor = null, NameConverterInterface $nameConverter = null, ClassMetadataFactoryInterface $classMetadataFactory = null, array $defaultContext = [], ResourceAccessCheckerInterface $resourceAccessChecker = null) | |||
There was a problem hiding this comment.
we can't change the constructor it's a public interface. Maybe that we should provide this from our DI?
There was a problem hiding this comment.
@soyuka maybe I should add a compiler pass to enforce the use of the default value when encountering an empty string?
762fb97 to
8f24a52
Compare
6c1ef3b to
5ca48a4
Compare
5ca48a4 to
7d093c1
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on symfony/symfony#47637 and taking into account #5514 , this PR aims to consider the
default_contextconfig option underserializerofFrameworkBundlewhen usingApiPlatform\JsonLd\Serializer\ItemNormalizer.Maybe we should check for the other normalizers.