Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(state): read without output #6347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soyuka merged 1 commit into from
May 3, 2024
Merged

fix(state): read without output #6347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/State/Provider/ReadProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,6 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
return null;
}

$output = $operation->getOutput() ?? [];
if (\array_key_exists('class', $output) && null === $output['class']) {
$request?->attributes->set('data', null);

return null;
}

if (null === $filters = $request?->attributes->get('_api_filters')) {
$queryString = RequestParser::getQueryString($request);
$filters = $queryString ? RequestParser::parseRequestParams($queryString) : null;
Expand Down
14 changes: 14 additions & 0 deletions src/State/Tests/Provider/ReadProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,18 @@ public function testSetsSerializerContext(): void
$provider->provide($operation, ['id' => 1], ['request' => $request]);
$this->assertEquals(['a'], $request->attributes->get('_api_normalization_context'));
}

public function testShouldReadWithOutputFalse(): void
{
$data = new \stdClass();
$operation = new Get(read: true, output: false);
$decorated = $this->createStub(ProviderInterface::class);
$decorated->method('provide')->willReturn($data);
$serializerContextBuilder = $this->createMock(SerializerContextBuilderInterface::class);
$serializerContextBuilder->expects($this->once())->method('createFromRequest')->willReturn(['a']);
$provider = new ReadProvider($decorated, $serializerContextBuilder);
$request = new Request();
$provider->provide($operation, ['id' => 1], ['request' => $request]);
$this->assertEquals($data, $request->attributes->get('data'));
}
}
10 changes: 9 additions & 1 deletion tests/Fixtures/TestBundle/ApiResource/Headers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,19 @@
status: 301,
output: false,
operations: [
new Get(uriTemplate: 'redirect_to_foobar'),
new Get(uriTemplate: 'redirect_to_foobar', provider: [self::class, 'provide']),
],
graphQlOperations: []
)]
class Headers
{
public $id;

public static function provide(): self
{
$s = new self();
$s->id = 1;

return $s;
}
}