Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add tests for the CachedResourceNameCollectionFactory class #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 1 commit into from
Nov 6, 2016
Merged

Add tests for the CachedResourceNameCollectionFactory class #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Metadata/Resource/Factory/CachedResourceNameCollectionFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,8 @@ public function create() : ResourceNameCollection
return $resourceNameCollection;
}

try {
$cacheItem->set($resourceNameCollection);
$this->cacheItemPool->save($cacheItem);
} catch (CacheException $e) {
// do nothing
}
$cacheItem->set($resourceNameCollection);
Copy link
Copy Markdown
Member Author

@meyerbaptiste meyerbaptiste Nov 4, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO there is no reason to catch a CacheException exception here because CacheItemPoolInterface::save() and CacheItemInterface::set() methods are not planning to throw an exception in their method definitions.

$this->cacheItemPool->save($cacheItem);

return $resourceNameCollection;
}
Expand Down
84 changes: 84 additions & 0 deletions tests/Metadata/Resource/Factory/CachedResourceNameCollectionFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
<?php

/*
* This file is part of the API Platform project.
*
* (c) Kévin Dunglas <[email protected]>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace ApiPlatform\Core\Tests\Metadata\Resource\Factory;

use ApiPlatform\Core\Metadata\Resource\Factory\CachedResourceNameCollectionFactory;
use ApiPlatform\Core\Metadata\Resource\Factory\ResourceNameCollectionFactoryInterface;
use ApiPlatform\Core\Metadata\Resource\ResourceNameCollection;
use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy;
use Psr\Cache\CacheException;
use Psr\Cache\CacheItemInterface;
use Psr\Cache\CacheItemPoolInterface;

/**
* @author Baptiste Meyer <[email protected]>
*/
class CachedResourceNameCollectionFactoryTest extends \PHPUnit_Framework_TestCase
{
public function testCreateWithItemHit()
{
$cacheItem = $this->prophesize(CacheItemInterface::class);
$cacheItem->isHit()->willReturn(true)->shouldBeCalled();
$cacheItem->get()->willReturn(new ResourceNameCollection([Dummy::class]))->shouldBeCalled();

$cacheItemPool = $this->prophesize(CacheItemPoolInterface::class);
$cacheItemPool->getItem(CachedResourceNameCollectionFactory::CACHE_KEY)->willReturn($cacheItem->reveal())->shouldBeCalled();

$decoratedResourceNameCollectionFactory = $this->prophesize(ResourceNameCollectionFactoryInterface::class);

$cachedResourceNameCollectionFactory = new CachedResourceNameCollectionFactory($cacheItemPool->reveal(), $decoratedResourceNameCollectionFactory->reveal());
$resultedResourceNameCollection = $cachedResourceNameCollectionFactory->create();

$this->assertInstanceOf(ResourceNameCollection::class, $resultedResourceNameCollection);
$this->assertEquals(new ResourceNameCollection([Dummy::class]), $resultedResourceNameCollection);
}

public function testCreateWithItemNotHit()
{
$resourceNameCollection = new ResourceNameCollection([Dummy::class]);

$decoratedResourceNameCollectionFactory = $this->prophesize(ResourceNameCollectionFactoryInterface::class);
$decoratedResourceNameCollectionFactory->create()->willReturn($resourceNameCollection)->shouldBeCalled();

$cacheItem = $this->prophesize(CacheItemInterface::class);
$cacheItem->isHit()->willReturn(false)->shouldBeCalled();
$cacheItem->set($resourceNameCollection)->willReturn($cacheItem->reveal())->shouldBeCalled();

$cacheItemPool = $this->prophesize(CacheItemPoolInterface::class);
$cacheItemPool->getItem(CachedResourceNameCollectionFactory::CACHE_KEY)->willReturn($cacheItem->reveal())->shouldBeCalled();
$cacheItemPool->save($cacheItem->reveal())->willReturn(true)->shouldBeCalled();

$cachedResourceNameCollectionFactory = new CachedResourceNameCollectionFactory($cacheItemPool->reveal(), $decoratedResourceNameCollectionFactory->reveal());
$resultedResourceNameCollection = $cachedResourceNameCollectionFactory->create();

$this->assertInstanceOf(ResourceNameCollection::class, $resultedResourceNameCollection);
$this->assertEquals(new ResourceNameCollection([Dummy::class]), $resultedResourceNameCollection);
}

public function testCreateWithGetCacheItemThrowsCacheException()
{
$decoratedResourceNameCollectionFactory = $this->prophesize(ResourceNameCollectionFactoryInterface::class);
$decoratedResourceNameCollectionFactory->create()->willReturn(new ResourceNameCollection([Dummy::class]))->shouldBeCalled();

$cacheException = $this->prophesize(CacheException::class);
$cacheException->willExtend(\Exception::class);

$cacheItemPool = $this->prophesize(CacheItemPoolInterface::class);
$cacheItemPool->getItem(CachedResourceNameCollectionFactory::CACHE_KEY)->willThrow($cacheException->reveal())->shouldBeCalled();

$cachedResourceNameCollectionFactory = new CachedResourceNameCollectionFactory($cacheItemPool->reveal(), $decoratedResourceNameCollectionFactory->reveal());
$resultedResourceNameCollection = $cachedResourceNameCollectionFactory->create();

$this->assertInstanceOf(ResourceNameCollection::class, $resultedResourceNameCollection);
$this->assertEquals(new ResourceNameCollection([Dummy::class]), $resultedResourceNameCollection);
}
}