feat(security): Add header and claim checks #486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @petski, Thanks for this security fix! Actually, this TokenHandler was a POC. A PR has been opened on Symfony to implement it without the Until then, your fix is welcome in this project :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add header and claim checks in
OidcDiscoveryTokenHandlerCurrently,
api/src/Security/Http/AccessToken/Oidc/OidcDiscoveryTokenHandler.phpdoesn't use aHeaderCheckerManagerand/or aClaimCheckerManagerto check claims likealgorexp.As a result, you can query the demo-API with an expired token. (I doublechecked this).
Don't be fooled by the call to
loadAndVerifyWithKeySet(), as it verifies the keys, not the claims.(The demo never claims it has this extra layer of security, so I think it's safe to consider this PR as a feature enhancement).