Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: duplicate skyfire description when listing tools multiple times #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

fix: duplicate skyfire description when listing tools multiple times #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 23 additions & 20 deletions src/mcp/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,29 @@ export class ActorsMcpServer {
for (const wrap of tools) {
this.tools.set(wrap.tool.name, wrap);
}
// Handle Skyfire mode modifications once per tool upsert
if (this.options.skyfireMode) {
for (const wrap of tools) {
if (wrap.type === 'actor'
|| (wrap.type === 'internal' && wrap.tool.name === HelperTools.ACTOR_CALL)
|| (wrap.type === 'internal' && wrap.tool.name === HelperTools.ACTOR_OUTPUT_GET)) {
// Add Skyfire instructions to description if not already present
if (!wrap.tool.description.includes(SKYFIRE_TOOL_INSTRUCTIONS)) {
wrap.tool.description += `\n\n${SKYFIRE_TOOL_INSTRUCTIONS}`;
}
// Add skyfire-pay-id property if not present
if (wrap.tool.inputSchema && 'properties' in wrap.tool.inputSchema) {
const props = wrap.tool.inputSchema.properties as Record<string, unknown>;
if (!props['skyfire-pay-id']) {
props['skyfire-pay-id'] = {
type: 'string',
description: SKYFIRE_PAY_ID_PROPERTY_DESCRIPTION,
};
}
}
}
}
}
if (shouldNotifyToolsChangedHandler) this.notifyToolsChangedHandler();
return tools;
}
Expand Down Expand Up @@ -419,26 +442,6 @@ export class ActorsMcpServer {
* @returns {object} - The response object containing the tools.
*/
this.server.setRequestHandler(ListToolsRequestSchema, async () => {
/**
* Hack for the Skyfire agentic payments, we check if Skyfire mode is enabled we ad-hoc add
* the `skyfire-pay-id` input property to all Actor tools and `call-actor` and `get-actor-output` tool.
*/
if (this.options.skyfireMode) {
for (const toolEntry of this.tools.values()) {
if (toolEntry.type === 'actor'
|| (toolEntry.type === 'internal' && toolEntry.tool.name === HelperTools.ACTOR_CALL)
|| (toolEntry.type === 'internal' && toolEntry.tool.name === HelperTools.ACTOR_OUTPUT_GET)) {
if (toolEntry.tool.inputSchema && 'properties' in toolEntry.tool.inputSchema) {
(toolEntry.tool.inputSchema.properties as Record<string, unknown>)['skyfire-pay-id'] = {
type: 'string',
description: SKYFIRE_PAY_ID_PROPERTY_DESCRIPTION,
};
}
// Update description to include Skyfire instructions
toolEntry.tool.description += `\n\n${SKYFIRE_TOOL_INSTRUCTIONS}`;
}
}
}
const tools = Array.from(this.tools.values()).map((tool) => getToolPublicFieldOnly(tool.tool));
return { tools };
});
Expand Down