Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Make sure that Actor instances with non-default configurations are also accessible through the global Actor proxy after initialization #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2025
Merged

fix: Make sure that Actor instances with non-default configurations are also accessible through the global Actor proxy after initialization #402

merged 5 commits into from
Feb 13, 2025

Conversation

janbuchar
Copy link
Contributor

@janbuchar
fix: Make sure that Actor instances with non-default configurations a…
3e77cca 
…re also accessible through the global Actor proxy after initialization
@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 13, 2025
@github-actions github-actions bot added this to the 108th sprint - Tooling team milestone Feb 13, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Feb 13, 2025
vdusek
vdusek reviewed Feb 13, 2025
View reviewed changes
vdusek
vdusek reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I tested it out, now the Actor() works for Scrapy Actors, which is great.

But the Actor.__init__ is still being called twice, am I correct?

@janbuchar
Copy link
Contributor Author

Ok, I tested it out, now the Actor() works for Scrapy Actors, which is great.

🎉

But the Actor.__init__ is still being called twice, am I correct?

That much is correct. Avoiding that would be tricky, though I'm sure it's doable. Yet, I was under the impression that it was not really a problem.

vdusek
vdusek approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM in that case

@janbuchar janbuchar merged commit b956a02 into master Feb 13, 2025
27 checks passed
@janbuchar janbuchar deleted the better-actor-proxy branch February 13, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@Pijukatel Pijukatel Awaiting requested review from Pijukatel

Assignees

@janbuchar janbuchar

Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
108th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

Constructor _ActorType.__init__ is being executed twice
2 participants
@janbuchar @vdusek