Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: prefer proxy password from env var #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

fix: prefer proxy password from env var #468

merged 1 commit into from
May 7, 2025

Conversation

stepskop
Copy link
Contributor

@stepskop stepskop commented May 7, 2025

Fetch proxy password from /user/me using ApifyEnvVars.TOKEN only when not passed through the constructor or ApifyEnvVars.PROXY_PASSWORD is not provided.

@stepskop stepskop requested review from B4nan and tobice May 7, 2025 13:45
@stepskop stepskop self-assigned this May 7, 2025
@stepskop stepskop added the adhoc Ad-hoc unplanned task added during the sprint. label May 7, 2025
@github-actions github-actions bot added this to the 114th sprint - Platform team milestone May 7, 2025
@github-actions github-actions bot added t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. labels May 7, 2025
@stepskop stepskop merged commit 1c4ad9b into master May 7, 2025
27 checks passed
@stepskop stepskop deleted the fix/proxy-pass-from-env-var branch May 7, 2025 14:50
@tobice tobice added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Jun 16, 2025
@Mantisus Mantisus mentioned this pull request Sep 4, 2025
Merged
vdusek pushed a commit that referenced this pull request Sep 5, 2025
@Mantisus
chore: add patch_propagate_logger fixture (#584)
f95a74d 
### Description

- Add patch_propagate_logger fixture.

### Issues

- Closes: #462

### Testing

Updated the
`test_initialize_with_manual_password_different_than_user_one` test, as
it did not correspond to the changes made earlier in #468.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

@B4nan B4nan B4nan approved these changes

@tobice tobice tobice approved these changes

Assignees

@stepskop stepskop

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
114th sprint - Platform team
Development

Successfully merging this pull request may close these issues.
4 participants
@stepskop @janbuchar @B4nan @tobice