feat: Add stats to ApifyRequestQueueClient
#574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApifyRequestQueueClient
vdusek
reviewed
Aug 29, 2025
Comment on lines
+1299
to
+1302
| metadata = await request_queue_force_cloud.get_metadata() | ||
|
|
||
| assert hasattr(metadata, 'stats') | ||
| apify_metadata = cast('ApifyRequestQueueMetadata', metadata) |
There was a problem hiding this comment.
I don't see much value in this, since typing casts are required anyway, instead of simply allowing extra fields in the Pydantic model, or omitting this altogether and using the Apify client directly.
There was a problem hiding this comment.
This is more about showing that force_cloud=True created RQ will have the stats. If that is the case, then it is implicitly proven that even the client has them.
There was a problem hiding this comment.
Sorry, I meant this whole PR, as we discussed on Slack here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ApifyRequestQueueMetadatathat contains Apify-specificRequestQueueStatsApifyRequestQueueClientIssues
statsto RequestQueue crawlee-python#1344