Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: improve max_request_retries and max_session_rotations documentation #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

barjin
Copy link
Contributor

@barjin barjin commented May 6, 2025

Improves the option documentation based on discussion.

Follow-up after apify/crawlee#2957.

@barjin barjin requested review from vdusek, Mantisus and Copilot May 6, 2025 14:36
@barjin barjin self-assigned this May 6, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label May 6, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the documentation for the crawler options by providing more detailed explanations for max_request_retries and max_session_rotations.

  • Expanded docstring for max_request_retries to clarify retry conditions and exclusions.
  • Updated max_session_rotations with details on its separation from retry counts.

@github-actions github-actions bot added this to the 114th sprint - Tooling team milestone May 6, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label May 6, 2025
Copy link
Collaborator

@Mantisus Mantisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barjin barjin merged commit bd4b940 into master May 6, 2025
23 checks passed
@barjin barjin deleted the docs/max-request-retries branch May 6, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants