Bugfix/only sent reply for non empty values #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryannel
reviewed
Jul 28, 2023
| value = source.olink_invoke(name, args) | ||
| self.emit_write(Protocol.invoke_reply_message(id, name, value)) | ||
| # only send reply for not empty values | ||
| if value: |
Contributor
There was a problem hiding this comment.
value could be int 0. I guess we would like to return an int 0 value or empty string. I guess you need to know if the value == None. Seems to be more safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
The python protocol implementation always send a return message on invoke regardless of whether the value actually was empty.
Following the other implementations we only send invoke_reply for non-empty values.
✅ Checks