add example of qml, add qml class description #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffbc6ae to
58bc9e0
Compare
w4bremer
approved these changes
Feb 3, 2023
Contributor
w4bremer
left a comment
There was a problem hiding this comment.
Minor issues, but looks good
jryannel
reviewed
Feb 7, 2023
Contributor
jryannel
left a comment
There was a problem hiding this comment.
often you can replace lower1 with camel. Typical qml modules use the dot separator. The main.qml should be structured that the visual parts come first and the interfaces are listed at the end.
52cf0d6 to
b35bdd8
Compare
b35bdd8 to
5734fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-method name start with lower first
-signal name starts with lower letter
-api factor for interface returns the shared_ptr<> instead of raw ptr
-change olink factory to get Client in constructor, and use it to link created interfaceClient on return
-added WRITE to QPROPERY in qml wrapper
-fixed a bug, where olink server added ")" to property and signal name