Dphan/fix examples #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7c8e3b to
29bc1aa
Compare
w4bremer
requested changes
Mar 20, 2023
Contributor
w4bremer
left a comment
There was a problem hiding this comment.
Typo in one the commits
adddres -> address
| {{- end }} | ||
|
|
||
|
|
||
| // You can run this client app together with the server side app - eiter also example, simulation, |
|
|
||
| // connect your singals here like | ||
| {{- if $features.monitor }} | ||
| // interfaceInstanceTraced.connect(&interfaceInstanceTraced, &Interface::propertyChanged, [](auto value){ qDebug() << " property changed " << value;}); |
Contributor
There was a problem hiding this comment.
You could use real interface names from the API?
Would be great if one of the two versions was actually "uncommented", so that there is always one version working there.
| #include <iostream> | ||
|
|
||
| int main(){ | ||
| // You can run this server app together with the client side app - eiter also example, |
Contributor
There was a problem hiding this comment.
What is the actual change in this file? Looks like nothing changed?
a6cede4 to
4effea5
Compare
170c01d to
d0a6ea5
Compare
e2ccfa2 to
5e720b4
Compare
w4bremer
requested changes
Mar 22, 2023
Contributor
There was a problem hiding this comment.
this probably should not have changed. Looks like a new line only change? Or do I miss the real change?
Remove loading non-existing qml Add documentation add possible usage in comment
Add using Qt engine without which the connection is not working. Add documentation
in qml example. The addresses didn't have "ws" part at the and of address.
5e720b4 to
5a70140
Compare
w4bremer
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup examples:
client and server are now console applications - with use of qt engine, which is necessary for connections
add few words of documentation to main.cpp
align missing "ws" in connection address