BREAKING CHANGE upgrade to object link 2.2 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w4bremer
approved these changes
Dec 6, 2022
w4bremer
requested changes
Dec 6, 2022
jryannel
approved these changes
Dec 6, 2022
|
|
||
| void OLinkRemote::writeMessage(const std::string msg) | ||
| { | ||
| qDebug() << Q_FUNC_INFO << QString::fromStdString(msg); |
Contributor
There was a problem hiding this comment.
will this slow down the message handling. On every msg we write the whole message out. Should we use maybe later the logging categories? Or remove these logs from code?
|
|
||
| void OLinkRemote::handleMessage(const QString &msg) | ||
| { | ||
| qDebug() << Q_FUNC_INFO << msg; |
Contributor
There was a problem hiding this comment.
samehere. debug on every message
| registry.addSource(testbed1OlinkStructArrayInterfaceService); | ||
|
|
||
| // Use the server. | ||
| registry.removeSource(testbed2OlinkManyParamInterfaceService->olinkObjectName()); |
Contributor
There was a problem hiding this comment.
can the registry remove all sources on destructor?
w4bremer
reviewed
Dec 6, 2022
w4bremer
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and make some fixes along the way
use dependecies for libs downloaded from repository instead of copying files
clean up shared folder
add examples - requires adding a namespace modulename::