Add support for linkText and partialLinkText search locators to @SelendroidFindBy annotation #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2014 12:05
…droidFindBy annotation
…droidFindBy annotation
Contributor
|
Good! :) But... Also. It is a little wish. What do think about the remaming of linktext and partiallinktext to text and partialtext? :) @SelendroidFindBy(text = "Accessibility")and @SelendroidFindBy(partialtext = "cessibilit")As all this work has been done for native contents so I think this strategy names are more meaningful. |
Contributor
Author
My opinion is keep it like it named in webdriver methods to conform naming across the api. More variation - more confusion. |
Contributor
|
ok! |
Jonahss
added a commit
that referenced
this pull request
Jan 5, 2015
Add support for linkText and partialLinkText search locators to @SelendroidFindBy annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @SelendroidFindBy(name="...") actually serches by accessibility id (according to selendroid documentation), I`ve added support for linkText and partialLinkText search strategies which searches by displayed element text.