Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mykola-mokhnach
Copy link
Contributor

Change list

Addresses SeleniumHQ/selenium#11168

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach mykola-mokhnach merged commit c7dcb1b into appium:master Oct 29, 2022
@mykola-mokhnach mykola-mokhnach deleted the screen branch October 29, 2022 18:06
@krishtoautomate
Copy link

Possible to create maven build of appium java client with this patch?

@sergey-lysenko
Copy link

This only fixed fullscreen screentshots, while calling method of WebElement falls back to default implementation and fails the test.

I guess the only option now (untill overriding is the only option) is to create a routine in tests which will make a full screenshot, then crop needed part based on WebElement's dimentions.

@mykola-mokhnach
Copy link
Contributor Author

This only fixed fullscreen screentshots, while calling method of WebElement falls back to default implementation and fails the test.

I guess the only option now (untill overriding is the only option) is to create a routine in tests which will make a full screenshot, then crop needed part based on WebElement's dimentions.

This patch is ugly and it anyway would make sense to apply it on Selenium side instead. Or simply use the newest version of an appium driver, where it generates a compatible base64-encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants