Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Providing W3C compliance #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TikhomirovSergey merged 15 commits into from
Feb 13, 2018
Merged

Providing W3C compliance #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
32c7b2a
Move NewSessionPayload so it can be used by ProtocolHandshake
shs96c Feb 9, 2018
3687731
Better docs for NewSessionPayload.stream
shs96c Feb 9, 2018
b67cfdc
Fix the Protocol Handshake
shs96c Feb 9, 2018
9a34f41
Rookie mistake: only include the w3c capabilities in the w3c capabili…
shs96c Feb 9, 2018
f860f33
Fix tests failing because of ProtocolHandshake
TikhomirovSergey Feb 9, 2018
ed5fba8
Ensure that we forward metadata in the new session payload
shs96c Feb 9, 2018
67588ec
Introducing new string constant for "platformName"
barancev Feb 9, 2018
264476a
Bump the java libraries we depend on to their latest versions
TikhomirovSergey Feb 9, 2018
fbb6e58
Use `Capabilities` rather than `ImmutableCapabilities` in mutators
TikhomirovSergey Feb 9, 2018
1855291
Update to selenium 3.9.1. Changes of NewSessionPayload.
TikhomirovSergey Feb 11, 2018
a79c624
fixing out:
TikhomirovSergey Feb 11, 2018
c23e05b
Removal of "magic" strings
TikhomirovSergey Feb 11, 2018
b694856
Improving set of not so major issues
TikhomirovSergey Feb 12, 2018
afa1039
`convertOssToW3C` marked by `Nullable`
TikhomirovSergey Feb 12, 2018
6ffd2ea
Fixing issuies before the merging
TikhomirovSergey Feb 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ compileJava {
]
}

ext.seleniumVersion = '3.8.1'
ext.seleniumVersion = '3.9.1'

dependencies {
compile ("org.seleniumhq.selenium:selenium-java:${seleniumVersion}") {
Expand Down
17 changes: 6 additions & 11 deletions src/main/java/io/appium/java_client/remote/MobileCapabilityType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ public interface MobileCapabilityType extends CapabilityType {
*/
String AUTOMATION_NAME = "automationName";

/**
* Which mobile OS platform to use.
*/
String PLATFORM_NAME = "platformName";
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where this constant is present now?

Copy link
Contributor Author

@TikhomirovSergey TikhomirovSergey Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in org.openqa.selenium.remote.CapabilityType

public interface MobileCapabilityType extends CapabilityType


/**
* Mobile OS version.
*/
Expand All @@ -61,12 +56,6 @@ public interface MobileCapabilityType extends CapabilityType {
*/
String APP = "app";

/**
* Name of mobile web browser to automate.
* Should be an empty string if automating an app instead.
*/
String BROWSER_NAME = "browserName";

/**
* Unique device identifier of the connected physical device.
*/
Expand Down Expand Up @@ -120,4 +109,10 @@ public interface MobileCapabilityType extends CapabilityType {
* (e.g., the start and end of each command, etc.). Defaults to false.
*/
String EVENT_TIMINGS = "eventTimings";

/**
* This is the flag which forces server to switch to the mobile WSONWP.
* If {@code false} then it is switched to W3C mode.
*/
String FORCE_MJSONWP = "forceMjsonwp";
}
Loading