Adds aliases to the dump-help output.
#813
Open
+84
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauhul
requested changes
Sep 16, 2025
| @@ -49,6 +49,8 @@ public struct CommandInfoV0: Codable, Hashable { | |||
|
|
|||
| /// Name used to invoke the command. | |||
| public var commandName: String | |||
| /// List of command aliases. | |||
| public var aliases: [String] | |||
There was a problem hiding this comment.
to maintain compatibility with tool info v1 we need to make this Optional
There was a problem hiding this comment.
Thanks! I'll make the change.
So I understand better (I'm new to the code, first PR), where would I need to look to know that? I just did a code search of the project for aliases and I didn't see any hints about this.
Is it just a rule that any new fields are Optional (it seems aliases was added later) to keep compatibility straightforward?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aliasesin the help dump. #812.Closes #812 by adding
aliasesto DumpHelpGenerator and ToolInfo.Checklist