add: env var. #10703
add: env var. #10703
Conversation
|
Warning Rate limit exceeded@ItzNotABug has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 51 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis change introduces a new console configuration variable Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings, 1 inconclusive)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
✨ Benchmark results
⚡ Benchmark Comparison
|
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/e2e/Services/Console/ConsoleConsoleClientTest.php (1)
27-42: Add explicit assertion for the new field.The count was correctly updated from 15 to 16, but there's no explicit assertion verifying that
_APP_CONSOLE_EMAIL_VERIFICATIONexists in the response and has the correct boolean type. Other boolean fields have explicit type assertions (lines 35-37).Add this assertion after line 41:
$this->assertIsString($response['body']['_APP_OPTIONS_FORCE_HTTPS']); $this->assertIsString($response['body']['_APP_DOMAINS_NAMESERVERS']); + $this->assertIsBool($response['body']['_APP_CONSOLE_EMAIL_VERIFICATION']); // When adding new keys, dont forget to update count a few lines above
🧹 Nitpick comments (1)
.env (1)
6-6: Variable placement follows logical grouping.The new environment variable is correctly added with a default value of
falseand positioned with other console-related configuration variables, which aids maintainability.Note: Static analysis suggests alphabetical ordering, but the current logical grouping (console variables together) is a reasonable organizational choice.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.env(1 hunks)app/controllers/api/console.php(1 hunks)docker-compose.yml(1 hunks)src/Appwrite/Utopia/Response/Model/ConsoleVariables.php(1 hunks)tests/e2e/Services/Console/ConsoleConsoleClientTest.php(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/Appwrite/Utopia/Response/Model/ConsoleVariables.php (1)
src/Appwrite/Utopia/Response/Model.php (1)
addRule(90-102)
🪛 dotenv-linter (4.0.0)
.env
[warning] 6-6: [UnorderedKey] The _APP_CONSOLE_EMAIL_VERIFICATION key should go before the _APP_EDITION key
(UnorderedKey)
🔇 Additional comments (3)
docker-compose.yml (1)
111-111: LGTM!The environment variable is correctly added to the appwrite service configuration and positioned logically with other console-related variables.
app/controllers/api/console.php (1)
87-87: LGTM!The environment variable is correctly sourced with an appropriate default value and properly integrated into the console variables response.
src/Appwrite/Utopia/Response/Model/ConsoleVariables.php (1)
108-118: LGTM!The new console variable rule is properly defined with appropriate type, description, default value, and example. The implementation follows the established pattern and is consistent with the rest of the model.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist