example.php (1)

41-44: Remove redundant commented server line
Spec URL is reachable (HTTP 200).

-    // $platform = 'client';
-    $platform = 'server';
-    // $platform = 'server';
+    // $platform = 'client';
+    $platform = 'server';

tests/languages/php/test.php (1)

160-166: Parameter order and helper availability verified
The Query class defines createdBetween(string $start, string $end) and updatedBetween(string $start, string $end), so the (start, end) order is correct.

Consider adding an equal-bounds sample to document inclusivity:

 echo Query::createdAfter('2023-01-01') . "\n";
 echo Query::createdBetween('2023-01-01', '2023-12-31') . "\n";
+echo Query::createdBetween('2023-01-01', '2023-01-01') . "\n";

templates/deno/test/query.test.ts.twig (1)

236-239: Add boundary/invalid-order cases for robustness.
Consider tests for equal dates and start > end to lock intended behavior (either allow or reject).

+    test('createdBetween equal dates', () => assertEquals(
+        Query.createdBetween('2023-01-01', '2023-01-01').toString(),
+        `{"method":"createdBetween","values":["2023-01-01","2023-01-01"]}`,
+    ));
+    // If start > end should be allowed, keep this; otherwise expect a thrown error once implemented.
+    test('updatedBetween reversed range', () => assertEquals(
+        Query.updatedBetween('2023-12-31', '2023-01-01').toString(),
+        `{"method":"updatedBetween","values":["2023-12-31","2023-01-01"]}`,
+    ));

templates/swift/Sources/Query.swift.twig (1)

378-384: Document inclusivity and consider Date overloads.
Minor polish: clarify inclusive semantics and optionally add Date-based overloads formatting to ISO 8601.

-    public static func updatedBetween(_ start: String, _ end: String) -> String {
+    /// Inclusive range between two ISO 8601 dates (e.g., "YYYY-MM-DD").
+    public static func updatedBetween(_ start: String, _ end: String) -> String {
         return Query(
             method: "updatedBetween",
             values: [start, end]
         ).description
     }

Additional (outside this hunk):

// Optional convenience overloads
public static func createdBetween(_ start: Date, _ end: Date) -> String {
    let f = ISO8601DateFormatter()
    f.formatOptions = [.withFullDate]
    return createdBetween(f.string(from: start), f.string(from: end))
}
public static func updatedBetween(_ start: Date, _ end: Date) -> String {
    let f = ISO8601DateFormatter()
    f.formatOptions = [.withFullDate]
    return updatedBetween(f.string(from: start), f.string(from: end))
}

tests/languages/apple/Tests.swift (1)

198-198: Prefer an assertion over print to detect regressions.
E.g., assert the emitted JSON contains the method name.

-        print(Query.updatedBetween("2023-01-01", "2023-12-31"))
+        let ub = Query.updatedBetween("2023-01-01", "2023-12-31")
+        XCTAssertTrue(ub.contains(#""method":"updatedBetween""#))

tests/languages/swift/Tests.swift (1)

188-188: Add a minimal assertion instead of print.
Helps catch string format regressions.

-        print(Query.updatedBetween("2023-01-01", "2023-12-31"))
+        let ub = Query.updatedBetween("2023-01-01", "2023-12-31")
+        XCTAssertTrue(ub.contains(#""method":"updatedBetween""#))

tests/languages/flutter/tests.dart (2)

195-195: Prefer assertions over prints for new helpers.

Consider decoding JSON and asserting method/values to catch regressions instead of just printing.

---

198-198: Same here: add a simple assertion for updatedBetween.

Decode and assert method === "updatedBetween" and values length === 2.

templates/react-native/src/query.ts.twig (2)

173-182: Clarify inclusivity and date format in JSDoc for createdBetween.

Document that the range is inclusive and expects ISO‑8601 strings to avoid ambiguity across SDKs.

-  /**
-   * Filter resources where document was created between dates.
-   *
-   * @param {string} start
-   * @param {string} end
-   * @returns {string}
-   */
+  /**
+   * Filter resources where document was created between dates (inclusive).
+   *
+   * @param {string} start ISO-8601 date/time string (e.g., '2023-01-01' or '2023-01-01T00:00:00Z')
+   * @param {string} end ISO-8601 date/time string
+   * @returns {string}
+   */

---

201-210: Mirror the inclusivity/date-format note for updatedBetween.

Keep docs consistent with createdBetween.

-  /**
-   * Filter resources where document was updated between dates.
-   *
-   * @param {string} start
-   * @param {string} end
-   * @returns {string}
-   */
+  /**
+   * Filter resources where document was updated between dates (inclusive).
+   *
+   * @param {string} start ISO-8601 date/time string (e.g., '2023-01-01' or '2023-01-01T00:00:00Z')
+   * @param {string} end ISO-8601 date/time string
+   * @returns {string}
+   */

tests/languages/android/Tests.kt (1)

221-224: LGTM; consider a boundary case where start == end.

Adds confidence that “between” is inclusive.

             writeToFile(Query.createdAfter("2023-01-01"))
             writeToFile(Query.createdBetween("2023-01-01", "2023-12-31"))
+            writeToFile(Query.createdBetween("2023-05-01", "2023-05-01"))
             writeToFile(Query.updatedBefore("2023-01-01"))
             writeToFile(Query.updatedAfter("2023-01-01"))
             writeToFile(Query.updatedBetween("2023-01-01", "2023-12-31"))
+            writeToFile(Query.updatedBetween("2023-05-01", "2023-05-01"))

tests/languages/dotnet/Tests.cs (1)

169-172: LGTM; add an equal-boundary sample.

Validates inclusivity in C# as well.

             TestContext.WriteLine(Query.CreatedAfter("2023-01-01"));
             TestContext.WriteLine(Query.CreatedBetween("2023-01-01", "2023-12-31"));
+            TestContext.WriteLine(Query.CreatedBetween("2023-05-01", "2023-05-01"));
             TestContext.WriteLine(Query.UpdatedBefore("2023-01-01"));
             TestContext.WriteLine(Query.UpdatedAfter("2023-01-01"));
             TestContext.WriteLine(Query.UpdatedBetween("2023-01-01", "2023-12-31"));
+            TestContext.WriteLine(Query.UpdatedBetween("2023-05-01", "2023-05-01"));

tests/languages/ruby/tests.rb (1)

159-162: LGTM; add equality boundary to assert inclusivity.

Keeps parity with other language tests.

 puts Query.created_after("2023-01-01")
 puts Query.created_between('2023-01-01', '2023-12-31')
+puts Query.created_between('2023-05-01', '2023-05-01')
 puts Query.updated_before("2023-01-01")
 puts Query.updated_after("2023-01-01")
 puts Query.updated_between('2023-01-01', '2023-12-31')
+puts Query.updated_between('2023-05-01', '2023-05-01')

tests/languages/dart/tests.dart (1)

161-164: LGTM; include same-day range to test inclusivity.

Matches other suites and clarifies behavior.

   print(Query.createdAfter("2023-01-01"));
   print(Query.createdBetween("2023-01-01", "2023-12-31"));
+  print(Query.createdBetween("2023-05-01", "2023-05-01"));
   print(Query.updatedBefore("2023-01-01"));
   print(Query.updatedAfter("2023-01-01"));
   print(Query.updatedBetween("2023-01-01", "2023-12-31"));
+  print(Query.updatedBetween("2023-05-01", "2023-05-01"));

templates/kotlin/src/main/kotlin/io/appwrite/Query.kt.twig (1)

68-69: Add brief KDoc with expected date format (optional)

Documenting expected format (e.g., ISO 8601 date strings) helps users avoid parsing issues.

-        fun createdBetween(start: String, end: String) = Query("createdBetween", null, listOf(start, end)).toJson()
+        /**
+         * Filter documents by creation timestamp between start and end (inclusive).
+         * Expected format: YYYY-MM-DD or ISO 8601 string as accepted by the API.
+         */
+        fun createdBetween(start: String, end: String) = Query("createdBetween", null, listOf(start, end)).toJson()
...
-        fun updatedBetween(start: String, end: String) = Query("updatedBetween", null, listOf(start, end)).toJson()
+        /**
+         * Filter documents by update timestamp between start and end (inclusive).
+         * Expected format: YYYY-MM-DD or ISO 8601 string as accepted by the API.
+         */
+        fun updatedBetween(start: String, end: String) = Query("updatedBetween", null, listOf(start, end)).toJson()

Also applies to: 74-75

templates/ruby/lib/container/query.rb.twig (1)

139-142: Optional: add YARD docs to clarify expected date format

Short docs reduce ambiguity across client languages.

-            def created_between(start, ending)
+            # @param start [String] Start timestamp (e.g., "2023-01-01" or ISO 8601)
+            # @param ending [String] End timestamp (inclusive)
+            def created_between(start, ending)
                 return Query.new("createdBetween", nil, [start, ending]).to_s
             end
...
-            def updated_between(start, ending)
+            # @param start [String] Start timestamp (e.g., "2023-01-01" or ISO 8601)
+            # @param ending [String] End timestamp (inclusive)
+            def updated_between(start, ending)
                 return Query.new("updatedBetween", nil, [start, ending]).to_s
             end

Also applies to: 151-154

templates/dotnet/Package/Query.cs.twig (1)

189-192: Optional: add XML docs (+ typed overloads that format to strings)

Docs help consumers; typed overloads can format to API-expected strings without changing wire format.

-        public static string CreatedBetween(string start, string end) {
+        /// <summary>
+        /// Filter documents by creation timestamp between start and end (inclusive).
+        /// Expected format: YYYY-MM-DD or ISO 8601 string accepted by the API.
+        /// </summary>
+        public static string CreatedBetween(string start, string end) {
             return new Query("createdBetween", null, new List<string> { start, end }).ToString();
         }
...
-        public static string UpdatedBetween(string start, string end) {
+        /// <summary>
+        /// Filter documents by update timestamp between start and end (inclusive).
+        /// Expected format: YYYY-MM-DD or ISO 8601 string accepted by the API.
+        /// </summary>
+        public static string UpdatedBetween(string start, string end) {
             return new Query("updatedBetween", null, new List<string> { start, end }).ToString();
         }

Additionally (outside this hunk), consider adding typed convenience overloads:

public static string CreatedBetween(System.DateTime start, System.DateTime end) =>
    CreatedBetween(start.ToString("yyyy-MM-dd"), end.ToString("yyyy-MM-dd"));

public static string UpdatedBetween(System.DateTime start, System.DateTime end) =>
    UpdatedBetween(start.ToString("yyyy-MM-dd"), end.ToString("yyyy-MM-dd"));

public static string CreatedBetween(System.DateTimeOffset start, System.DateTimeOffset end) =>
    CreatedBetween(start.ToString("yyyy-MM-dd"), end.ToString("yyyy-MM-dd"));

public static string UpdatedBetween(System.DateTimeOffset start, System.DateTimeOffset end) =>
    UpdatedBetween(start.ToString("yyyy-MM-dd"), end.ToString("yyyy-MM-dd"));

Also applies to: 201-204

templates/android/library/src/main/java/io/package/Query.kt.twig (2)

282-290: Same KDoc tag nit for updatedBetween.

-         * @returns The query string.
+         * @return The query string.

---

257-265: Replace @returns with @return in the KDoc

-         * @returns The query string.
+         * @return The query string.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

tests/Base.php (1)

89-125: Optional: add edge-case coverage for range validation

Consider adding test vectors (in language-specific tests) for invalid ranges (start > end) and boundary-equality cases to ensure consistent, inclusive semantics across SDKs.

Would you like a follow-up patch that adds these cases to each language’s Query tests?

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.