chore: remove avatars command from cli #1191
Conversation
WalkthroughThe change updates example.php to add "avatars" to the services exclusion list within setExclude for CLI SDK generation, alongside "assistant". As a result, the avatars service is omitted from generated CLI SDKs. No other code paths, error handling, or public API signatures are modified. Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
example.php (1)
192-198: Tiny clarity nit: document why avatars is excludedA brief inline comment helps future readers understand the rationale and link it to the tracking issue.
Apply:
->setDefaultHeaders([ 'X-Appwrite-Response-Format' => '1.7.0', ]) - ->setExclude([ + // Exclude avatars from CLI (see sdk-for-cli#86) + ->setExclude([ 'services' => [ ['name' => 'assistant'], ['name' => 'avatars'], ], ])
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
example.php(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: build (8.3, Android14Java17)
- GitHub Check: build (8.3, Swift56)
- GitHub Check: build (8.3, DartStable)
- GitHub Check: build (8.3, AppleSwift56)
- GitHub Check: build (8.3, KotlinJava11)
- GitHub Check: build (8.3, KotlinJava8)
🔇 Additional comments (1)
example.php (1)
193-197: LGTM: avatars service correctly excluded from CLI generationMatches the PR goal; array shape and placement under setExclude('services') look correct. Please just confirm the console spec actually exposes the 'avatars' service; otherwise this is a no-op.
Run to verify presence of the service in the referenced spec:
#!/bin/bash set -euo pipefail version='1.8.x' platform='console' url="https://raw.githubusercontent.com/appwrite/appwrite/${version}/app/config/specs/swagger2-${version}-${platform}.json" tmp="$(mktemp)" curl -fsSL "$url" -o "$tmp" echo "Tags including 'avatars':" jq -r '.tags[]?.name' "$tmp" | rg -n '^avatars$' || echo "No 'avatars' tag found" echo "Paths mentioning avatars:" jq -r '.paths | keys[]' "$tmp" | rg -n 'avatars' || echo "No avatar-related paths found" rm -f "$tmp"
What does this PR do?
Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes.
Summary by CodeRabbit