[fix] Persistent index creation fails. #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm the bug exists and the fix works, thanks @aquamatthias ! |
|
@tjoubert going forward let's use snake_case for Python code and camelCase for API responses/results. |
joowani
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating to ArangoDB 3.10, the driver is no longer able to create persistent indexes.
Error:
The value for storedValues is set to an empty list by default which yields an error.
Instead it should be unset by default.
Plus:
I also realised that the parameters do not adhere to the naming convention in the library.
The parameter should be named
stored_valuesinstead ofstoredValues(same goes forcacheEnabled).I left the name, but can also fix this as part of this PR if you want me to do this.
Reference: someengineering/fixinventory#1294