-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add library request: KeyboardAzertyFr #6896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Please update the After doing so, please comment here to let us know we can proceed with adding your library to the Library Manager index. For more information see: |
I'm not sure of exactly what to do but I tried to follow your instructions. Is this Okay ? : https://github.com/martin-leo/KeyboardAzertyFr/releases/tag/1.0.1-fr |
Here's my concern: In Semver when you append a hypen and then a string to a version number that's considered a pre-release. So that means that 1.0.1 actually has precedence over 1.0.1-fr. This could possibly cause two different problems: The permanent name chosen by Library Manager for the library.
In the GitHub releases page 1.0.1-fr is indeed shown as the latest release but I don't know whether the Library Manager indexer uses Semver version order to determine what is considered the "latest release". The other concern would be that, even if the correct name is chosen, when someone installs a library via Library Manager the highest version number is chosen by default, which should be 1.0.1, not 1.0.1-fr. If you want to install a different version then you need to choose it from the version menu and even then if it's not the latest version and the user has update notifications enabled then they will get nagged by the IDE to "update" the library even though in this case that would mean a downgrade since it would mean replacing 1.0.1-fr with 1.0.1. That's all just my suspicions. I don't know whether any of that would happen or whether Library Manager will be able to ignore the inherited releases. @cmaglie is the expert on this and he can give a definitive verdict on this when he gets a chance to review this request. If it does end up being a problem I see a couple of options to fix it:
|
Thank you for this long (not too much), documented and useful answer. Based on this information I chose to :
Do you think this will do ? I do not mind to do some additional modification if it can be improved. |
You forgot to change the Please comment once you have resolved the |
I changed the |
Done! |
Hello,
I made a Keyboard library fork to support the french azerty keyboard layout.
You can check it at this address : https://github.com/martin-leo/KeyboardAzertyFr
Best regards.
The text was updated successfully, but these errors were encountered: