Fix core upgrading not uninstalling unused tools #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
- ✔️ Tool removed on upgrade when it's not dependency of any other platform (e.g., upgrade from
arduino:[email protected]removesarduino:[email protected]) - ✔️ Tool not removed on upgrade when it's a dependency of other platform (e.g., upgrade from
arduino:[email protected]leavesarduino:[email protected]whenarduino:[email protected]is installed) - ✔️ Tool not removed on upgrade when it's a dependency of other platform that doesn't have installed.json (i.e., installed via classic Arduino IDE)
Thanks Silvano!
d46b3be to
80042c8
Compare
80042c8 to
56407ba
Compare
per1234
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
The previous results I reported were done using arduino-cli core install and arduino-cli core upgrade. The integration tests revealed a problem specific to arduino-cli upgrade, which has been fixed.
I have now repeated the tests, this time including arduino-cli upgrade and found everything to be working as expected. I was able to reproduce the arduino-cli upgrade issue before the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixes an existing command.
core install,core upgradeandupgradecommands don't remove necessary tools used by the previously installed core version but unused by the newly installed one.core install,core upgradeandupgradecommands now remove unused tools if the core that is being upgraded doesn't need them in the new version.titled accordingly?
Nope.
None.
See how to contribute