Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: discovery cleanup and watchers continuity upon core install #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 15, 2023
Merged

fix: discovery cleanup and watchers continuity upon core install #2062

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a42a487
fix: clear discovery manager when spawing a new one
Feb 1, 2023
1b6d1c1
test: fix failing test
Feb 3, 2023
b73907b
chore: rm useless comment
Feb 13, 2023
27625c5
refactor: pr comments
Bikappa Feb 28, 2023
fbce838
chore: removed comment
Bikappa Mar 9, 2023
147179e
Update arduino/discovery/discoverymanager/discoverymanager.go
Bikappa Mar 9, 2023
35a4eea
fix: unused var
Bikappa Mar 9, 2023
61ac16a
fix: initialize in builder
Bikappa Mar 13, 2023
f661846
fix: merge error
Bikappa Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: initialize in builder
  • Loading branch information
@Bikappa
Bikappa committed Mar 13, 2023
commit 61ac16aaf663b48235e51a0368eb09dec8aeaf91
21 changes: 13 additions & 8 deletions arduino/cores/packagemanager/package_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,20 +98,25 @@ func (pmb *Builder) BuildIntoExistingPackageManager(target *PackageManager) {
target.tempDir = pmb.tempDir
target.packagesCustomGlobalProperties = pmb.packagesCustomGlobalProperties
target.profile = pmb.profile
if target.discoveryManager != nil {
target.discoveryManager.Clear()
} else {
target.discoveryManager = pmb.discoveryManager
}
target.discoveryManager.Clear()
target.discoveryManager.AddAllDiscoveriesFrom(pmb.discoveryManager)
target.userAgent = pmb.userAgent
}

// Build builds a new PackageManager.
func (pmb *Builder) Build() *PackageManager {
res := &PackageManager{}
pmb.BuildIntoExistingPackageManager(res)
return res
return &PackageManager{
log: pmb.log,
packages: pmb.packages,
IndexDir: pmb.IndexDir,
PackagesDir: pmb.PackagesDir,
DownloadDir: pmb.DownloadDir,
tempDir: pmb.tempDir,
packagesCustomGlobalProperties: pmb.packagesCustomGlobalProperties,
profile: pmb.profile,
discoveryManager: pmb.discoveryManager,
userAgent: pmb.userAgent,
}
}

// NewBuilder creates a Builder with the same configuration
Expand Down