Added ObjFileIsUpToDate method to sourceFile

arduino · cmaglie · Jul 25, 2025 · May 31, 2024 · Jun 1, 2024 · Jun 2, 2024
commit eee25d119aacfbfd2fbde36ccc6ae657d349f13f
diff --git a/internal/arduino/builder/internal/detector/detector.go b/internal/arduino/builder/internal/detector/detector.go
@@ -321,8 +321,6 @@ func (l *SketchLibrariesDetector) findMissingIncludesInCompilationUnit(
 ) error {
 	sourceFile := sourceFileQueue.Pop()
 	sourcePath := sourceFile.SourcePath
-	depPath := sourceFile.DepfilePath
-	objPath := sourceFile.ObjectPath
 
 	// TODO: This should perhaps also compare against the
 	// include.cache file timestamp. Now, it only checks if the file
@@ -336,7 +334,7 @@ func (l *SketchLibrariesDetector) findMissingIncludesInCompilationUnit(
 	// TODO: This reads the dependency file, but the actual building
 	// does it again. Should the result be somehow cached? Perhaps
 	// remove the object file if it is found to be stale?
-	unchanged, err := utils.ObjFileIsUpToDate(sourcePath, objPath, depPath)
+	unchanged, err := sourceFile.ObjFileIsUpToDate()
 	if err != nil {
 		return err
 	}

diff --git a/internal/arduino/builder/internal/detector/source_file.go b/internal/arduino/builder/internal/detector/source_file.go
@@ -19,6 +19,7 @@ import (
 	"fmt"
 	"slices"
 
+	"github.com/arduino/arduino-cli/internal/arduino/builder/internal/utils"
 	"github.com/arduino/go-paths-helper"
 )
 
@@ -80,6 +81,11 @@ func makeSourceFile(sourceRoot, buildRoot, sourceFilePath *paths.Path, extraIncl
 	return res, nil
 }
 
+// ObjFileIsUpToDate checks if the compile object file is up to date.
+func (f *sourceFile) ObjFileIsUpToDate() (unchanged bool, err error) {
+	return utils.ObjFileIsUpToDate(f.SourcePath, f.ObjectPath, f.DepfilePath)
+}
+
 // uniqueSourceFileQueue is a queue of source files that does not allow duplicates.
 type uniqueSourceFileQueue []*sourceFile