Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Multiple gRPC Create/Init/Destroy cycles causes multiple pluggable-discovery zombie process #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2025
Merged

fix: Multiple gRPC Create/Init/Destroy cycles causes multiple pluggable-discovery zombie process #2985

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9522f68
Refactor mocked-discovery integration tests
cmaglie Aug 27, 2025
baa2ab0
Added integration-test to check handling of multiple discovery instances
cmaglie Aug 27, 2025
236742c
Correctly clean-up pluggable-discoveries on gRPC instance close
cmaglie Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor mocked-discovery integration tests
  • Loading branch information
@cmaglie
cmaglie committed Aug 27, 2025
commit 9522f687ea796296b63405ad36aa637475e2a11e
73 changes: 25 additions & 48 deletions internal/integrationtest/board/board_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,23 +71,6 @@ func TestCorrectBoardListOrdering(t *testing.T) {
]`)
}

func TestBoardList(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()

_, _, err := cli.Run("core", "update-index")
require.NoError(t, err)

cli.InstallMockedSerialDiscovery(t)

stdout, _, err := cli.Run("board", "list", "--json")
require.NoError(t, err)
// check is a valid json and contains a list of ports
requirejson.Parse(t, stdout).
Query(`[ .detected_ports | .[].port | select(.protocol == null or .protocol_label == null) ]`).
MustBeEmpty()
}

func TestBoardListMock(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()
Expand All @@ -97,11 +80,20 @@ func TestBoardListMock(t *testing.T) {

cli.InstallMockedSerialDiscovery(t)

stdout, _, err := cli.Run("board", "list", "--json")
require.NoError(t, err)
t.Run("IsValidJsonPortList", func(t *testing.T) {
// 1. Check is a valid JSON
// 2. Check is a valid port list (has address/protocol)
stdout, _, err := cli.Run("board", "list", "--json")
require.NoError(t, err)
requirejson.Parse(t, stdout).
Query(`[ .detected_ports | .[].port | select(.address == null or .protocol == null) ]`).
MustBeEmpty()
})

// check is a valid json and contains a list of ports
requirejson.Contains(t, stdout, `{
t.Run("ContainsMockedPorts", func(t *testing.T) {
stdout, _, err := cli.Run("board", "list", "--json")
require.NoError(t, err)
requirejson.Contains(t, stdout, `{
"detected_ports": [
{
"matching_boards": [
Expand All @@ -124,35 +116,20 @@ func TestBoardListMock(t *testing.T) {
}
}
]
}`)
}

func TestBoardListWithFqbnFilter(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()

_, _, err := cli.Run("core", "update-index")
require.NoError(t, err)

cli.InstallMockedSerialDiscovery(t)

stdout, _, err := cli.Run("board", "list", "-b", "foo:bar:baz", "--json")
require.NoError(t, err)
requirejson.Query(t, stdout, `.detected_ports | length`, `0`)
}

func TestBoardListWithFqbnFilterInvalid(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()

_, _, err := cli.Run("core", "update-index")
require.NoError(t, err)
}`)
})

cli.InstallMockedSerialDiscovery(t)
t.Run("ListWithFqbnFilter", func(t *testing.T) {
stdout, _, err := cli.Run("board", "list", "-b", "foo:bar:baz", "--json")
require.NoError(t, err)
requirejson.Query(t, stdout, `.detected_ports | length`, `0`)
})

_, stderr, err := cli.Run("board", "list", "-b", "yadayada", "--json")
require.Error(t, err)
requirejson.Query(t, stderr, ".error", `"Invalid FQBN: not an FQBN: yadayada"`)
t.Run("ListWithFqbnFilterInvalid", func(t *testing.T) {
_, stderr, err := cli.Run("board", "list", "-b", "yadayada", "--json")
require.Error(t, err)
requirejson.Query(t, stderr, ".error", `"Invalid FQBN: not an FQBN: yadayada"`)
})
}

func TestBoardListall(t *testing.T) {
Expand Down