Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: simplify board and port handling #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 18, 2023
Merged

feat: simplify board and port handling #2165

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e684eec
feat: simplify board and port handling
Sep 1, 2022
c067ce5
fix: aligned import
Aug 17, 2023
6582b9b
fix: remove mock code
Aug 17, 2023
4a393ba
fix: use type import
Aug 17, 2023
530cddb
fix: remove obsolete workaround code
Aug 17, 2023
b3b731a
fix(regression): restore the `Unknown` board label
Aug 18, 2023
16e1eda
chore(cli): use `38479dc` CLI
Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove mock code
  • Loading branch information
Akos Kitta committed Aug 17, 2023
commit 6582b9b1bece3077ee012903f4a988946ac1f30f
125 changes: 0 additions & 125 deletions arduino-ide-extension/src/node/board-discovery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,131 +249,6 @@ export class BoardDiscovery
return undefined;
}
const port = createApiPort(rpcPort);
// if (port.address === '/dev/cu.Bluetooth-Incoming-Port') {
// return {
// port: {
// address: 'COM41',
// addressLabel: 'COM41',
// protocol: 'serial',
// protocolLabel: 'Serial Port (USB)',
// properties: {
// pid: '0x1001',
// serialNumber: '',
// vid: '0x303A',
// },
// },
// boards: [
// {
// name: 'Adafruit QT Py ESP32-C3',
// fqbn: 'esp32:esp32:adafruit_qtpy_esp32c3',
// },
// {
// name: 'AirM2M_CORE_ESP32C3',
// fqbn: 'esp32:esp32:AirM2M_CORE_ESP32C3',
// },
// {
// name: 'Crabik Slot ESP32-S3',
// fqbn: 'esp32:esp32:crabik_slot_esp32_s3',
// },
// {
// name: 'DFRobot Beetle ESP32-C3',
// fqbn: 'esp32:esp32:dfrobot_beetle_esp32c3',
// },
// {
// name: 'DFRobot Firebeetle 2 ESP32-S3',
// fqbn: 'esp32:esp32:dfrobot_firebeetle2_esp32s3',
// },
// {
// name: 'DFRobot Romeo ESP32-S3',
// fqbn: 'esp32:esp32:dfrobot_romeo_esp32s3',
// },
// {
// name: 'ESP32C3 Dev Module',
// fqbn: 'esp32:esp32:esp32c3',
// },
// {
// name: 'ESP32S3 Dev Module',
// fqbn: 'esp32:esp32:esp32s3',
// },
// {
// name: 'ESP32-S3-Box',
// fqbn: 'esp32:esp32:esp32s3box',
// },
// {
// name: 'ESP32S3 CAM LCD',
// fqbn: 'esp32:esp32:esp32s3camlcd',
// },
// {
// name: 'ESP32-S3-USB-OTG',
// fqbn: 'esp32:esp32:esp32s3usbotg',
// },
// {
// name: 'Heltec WiFi Kit 32(V3)',
// fqbn: 'esp32:esp32:heltec_wifi_kit_32_V3',
// },
// {
// name: 'Heltec WiFi LoRa 32(V3) / Wireless shell(V3) / Wireless stick lite (V3)',
// fqbn: 'esp32:esp32:heltec_wifi_lora_32_V3',
// },
// {
// name: 'LilyGo T-Display-S3',
// fqbn: 'esp32:esp32:lilygo_t_display_s3',
// },
// {
// name: 'LOLIN C3 Mini',
// fqbn: 'esp32:esp32:lolin_c3_mini',
// },
// {
// name: 'LOLIN S3',
// fqbn: 'esp32:esp32:lolin_s3',
// },
// {
// name: 'M5Stack-ATOMS3',
// fqbn: 'esp32:esp32:m5stack-atoms3',
// },
// {
// name: 'M5Stack-CoreS3',
// fqbn: 'esp32:esp32:m5stack-cores3',
// },
// {
// name: 'Nebula S3',
// fqbn: 'esp32:esp32:nebulas3',
// },
// {
// name: 'u-blox NORA-W10 series (ESP32-S3)',
// fqbn: 'esp32:esp32:nora_w10',
// },
// {
// name: 'RedPill(+) ESP32-S3',
// fqbn: 'esp32:esp32:redpill_esp32s3',
// },
// {
// name: 'STAMP-S3',
// fqbn: 'esp32:esp32:stamp-s3',
// },
// {
// name: 'TAMC Termod S3',
// fqbn: 'esp32:esp32:tamc_termod_s3',
// },
// {
// name: 'VALTRACK_V4_MFW_ESP32_C3',
// fqbn: 'esp32:esp32:VALTRACK_V4_MFW_ESP32_C3',
// },
// {
// name: 'VALTRACK_V4_VTS_ESP32_C3',
// fqbn: 'esp32:esp32:VALTRACK_V4_VTS_ESP32_C3',
// },
// {
// name: 'WiFiduinoV2',
// fqbn: 'esp32:esp32:wifiduino32c3',
// },
// {
// name: 'WiFiduino32S3',
// fqbn: 'esp32:esp32:wifiduino32s3',
// },
// ],
// };
// }
const boards = detectedPort.getMatchingBoardsList().map(
(board) =>
({
Expand Down