Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 4, 2019. It is now read-only.

Feature/16 define a style standard #25

Merged
merged 3 commits into from
Dec 2, 2017

Conversation

JonasProgrammer
Copy link

No description provided.

- .editorconfig for cross-editor support
  - 4 spaces instead of tabs
  - LF eol
  - final new line
  - continuation indent 8
  - no trailing whitespace
- formatted existing code accordingly
- changed gitignore to allow project-specific IDEA code style settings
- added .gitattributes to ensure LF checkout even on Windows (a fresh checkout might be required)
@@ -0,0 +1,44 @@
<component name="ProjectCodeStyleConfiguration">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file truly needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's both the files that my beloved sea lion created after opening the project with the latest version.

Looking at https://confluence.jetbrains.com/display/IDEADEV/New+project+code+style+settings+format+in+2017.3 it seems that both files are safe to put in a VCS. While it also states 'the latter [Project.xml] is optional', it then refers it to be created when something differs from the default settings. The 'empty' file being created in my case is probably due to me having some non-standard settings for my default settings, whereas here I rolled back to the default.

Long story short, it seems not to harm anyone and force-pull settings back to default when somebody uses custom settings as their IDE default, thus IMHO it can stay there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, thanks for sharing the update.

@MrPointer MrPointer merged commit 13566ae into release/2.0.0 Dec 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants