Fixed excessive memory consumption #38
Conversation
| @@ -48,11 +48,11 @@ function(make_arduino_library VAR_NAME BOARD_ID LIB_PATH COMPILE_FLAGS LINK_FLAG | |||
| endforeach () | |||
|
|
|||
| if (LIB_INCLUDES) | |||
| string(REPLACE ";" " " LIB_INCLUDES "${LIB_INCLUDES}") | |||
| string(REPLACE ";" " " LIB_INCLUDES_SPACE_SEPARATED "${LIB_INCLUDES}") | |||
There was a problem hiding this comment.
Only the compiler command line generated with set_target_properties below requires a space separated version of LIB_INCLUDES.
If we replace the ; in the cmake list LIB_INCLUDES, the list(REMOVE_DUPLICATES LIB_INCLUDES) call at the end of the function does not remove anything.
|
@noseglasses |
|
I can check this, but not sure how to do it? :) |
|
This PR changes two lines. If you did not change the respective lines or just moved them elsewhere, the problem will persist. As you apparently did not run into the problems I encountered (computer stalling because of memory exhaustion), you probably did not touch the respective lines. |
|
It is hard to tell whether I changed it or not because I refactored a lot of things, added and removed something in the process. So it is hard for me to tell if I fixed this problem or not because I never encountered theses issues in the first place :) so that's why I'm asking to check my branch if you encounter this problem, you'll see if it's gone or not. |
Nested calls to
make_arduino_librarycause an exponential groth of theLIB_INCLUDESvariable. This PR fixes it.