Add getDirection() support to ModulinoKnob and example ⚡
#34
Conversation
Added support for character and string-based input to `isPressed()` in `ModulinoButtons`, so it now accepts both index (0–2) and letter identifiers (`'A'`, `'B'`, `'C'`) matching the physical button labeling. Closes arduino-libraries#3
.gitignore
Outdated
There was a problem hiding this comment.
Remove this file.
It is already included in the PR #33
There was a problem hiding this comment.
Revert this file :)
this modifies doesn't add any feature to the PR
src/Modulino.h
Outdated
| @@ -255,12 +256,27 @@ class ModulinoKnob : public Module { | |||
| } | |||
| return ret; | |||
| } | |||
| int16_t get() { | |||
There was a problem hiding this comment.
remove it.
it is already included in the PR #32
src/Modulino.h
Outdated
| uint8_t buf[3]; | ||
| auto res = read(buf, 3); | ||
| if (res == false) { | ||
| return 0; | ||
| } | ||
| get(buf); |
There was a problem hiding this comment.
same here
it is already included in the PR #32
|
@leonardocavagnis I apologize for creating problems with the files but I had accidentally merged the changes of PR #33 into the With commit 66200f1 this PR is affected to pull request is merged indirectly or is still processing updates. For this reason with commit cff95ab everything should be fixed correctly. I remain waiting for further developments. Enjoy 🎉 |
📝 Description
This PR introduces support for detecting rotation direction in the
ModulinoKnobclass via a new method:getDirection()returns1for clockwise,-1for counter-clockwise, and0when no movement is detected (debounced).DEBOUNCE_DELAYto avoid noisy reads.begin()logic now initializes internal state (_lastPosition,_lastDebounceTime) accordingly.getDirection().🔁 Related Work
Fixed #9