ADBDEV-7188 Eliminate SSL renegotiation from gpfdist #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RekGRpth
approved these changes
Feb 26, 2025
silent-observer
approved these changes
Feb 26, 2025
Merged
whitehawk
pushed a commit
that referenced
this pull request
Jun 29, 2025
SSL renegotiation is considered insecure and vulnerable and was eliminated in TLS v1.3. However, when using older clients, we want to ensure that renegotiation is not used, so we explicitly disable it whenever possible. This commit removes SSL renegotiation setup from gpfdist. Additionally, disabling SSL renegotiation in this commit resolves an issue with TLS v1.2, specifically an incompatibility between OpenSSL 1.0.2k and GnuTLS during server-initiated renegotiation. Testing this incompatibility requires a non-trivial setup, involving gpfdist built with OpenSSL 1.0.2k and a client (ADB or curl) built with GnuTLS. Since this setup is not achievable using the current build and test system, only manual setup and testing are possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL renegotiation is considered insecure and vulnerable and was eliminated in
TLS v1.3.
However, when using older clients, we want to ensure that renegotiation is not
used, so we explicitly disable it whenever possible.
This commit removes SSL renegotiation setup from gpfdist.
Additionally, disabling SSL renegotiation in this commit resolves an issue with
TLS v1.2, specifically an incompatibility between OpenSSL 1.0.2k and GnuTLS
during server-initiated renegotiation.
Testing this incompatibility requires a non-trivial setup, involving gpfdist
built with OpenSSL 1.0.2k and a client (ADB or curl) built with GnuTLS. Since
this setup is not achievable using the current build and test system, only
manual setup and testing are possible.