Fix print KB in explain's output #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExplainPropertyInteger() is used to print int64 in explain's output. It requires int64 variable to correctly convert number to string. At some places double is used instead of int. Also at some places bytes were not convert to kilobytes, but were printed with "KB". Patch adds converting double to int64 and bytes to kilobytes. Test was not added, because values of usage memory in the explain's output are ignored at all tests.
silent-observer
approved these changes
Jun 10, 2025
bimboterminator1
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix print KB in explain's output
ExplainPropertyInteger() is used to print int64 in explain's output. It requires
int64 variable to correctly convert number to string. At some places double is
used instead of int. Also at some places bytes were not convert to kilobytes,
but were printed with "KB". Patch adds converting double to int64 and bytes to
kilobytes. Variable total_memory_across_slices was removed, because it's value
is not changed and is always zero.
Test was not added, because values of usage memory in the explain's
output are ignored at all tests.