ADBDEV-8107: Move private declarations back to public in cdbendpoint.h #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andr-sokolov
approved these changes
Aug 22, 2025
bimboterminator1
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move private declarations back to public in cdbendpoint.h
In GPDB 6, declarations for endpoint_token_str2arr and ENDPOINT_TOKEN_ARR_LEN
were in cdb/cdbendpoint.h, but were moved to
cdb/endpoint/cdbendpoint_private.h by commit
7a1ce37 in GPDB 7. However, we still need
those as public for adb_fdw, so we should move them back.