Implement skeleton for basic shrink scenario #1971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkovalev1
reviewed
Sep 8, 2025
dkovalev1
reviewed
Sep 10, 2025
dkovalev1
reviewed
Sep 12, 2025
dkovalev1
reviewed
Sep 12, 2025
dkovalev1
reviewed
Sep 12, 2025
|
In general it looks good to me, basic scenario worked for me, just a few more cosmetic changes please. |
dkovalev1
approved these changes
Sep 14, 2025
bimboterminator1
approved these changes
Sep 19, 2025
Member
bimboterminator1
left a comment
There was a problem hiding this comment.
LGTM, the state machine apprach is brilliantly implemented
bandetto
reviewed
Sep 21, 2025
Member
|
Should we use a formatter for new python code? autopep8 or black/ruff? |
bandetto
reviewed
Sep 21, 2025
Author
As long as we haven't agreed on the Python's linter to use across the entire product, I consider it as out of scope of this task. |
bandetto
reviewed
Sep 22, 2025
bandetto
approved these changes
Sep 23, 2025
bimboterminator1
approved these changes
Sep 23, 2025
dkovalev1
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement skeleton for basic shrink scenario
This patch implements a state machine skeleton for a basic shrink scenario based
on 'transitions' library. It consists of a new 'ggrebalance' tool, which will be
a single entry point for shrink, expand, and cluster rebalance functionality,
and 'shrink.py', which contains the state machine itself with the shrink logic.
The main purpose of this half-MVP is to evaluate the state machine pattern
suitability. Therefore it implements only a limited set of requirements for the
shrink, which allows you to support basic shrink workflow.