ADBM-2033: Add --set filtering for archive verification #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d18054 to
37090cb
Compare
KnightMurloc
reviewed
Feb 5, 2025
KnightMurloc
reviewed
Feb 6, 2025
KnightMurloc
previously approved these changes
Feb 6, 2025
dkovalev1
reviewed
Feb 7, 2025
src/command/verify/verify.c
Outdated
| true, jobData->manifestCipherPass); | ||
| } | ||
|
|
||
| // If the main file did not error, then save WAL range of the backup |
There was a problem hiding this comment.
May be did not error -> has no error ?
and manifest file instead of main file?
dkovalev1
reviewed
Feb 7, 2025
dkovalev1
approved these changes
Feb 7, 2025
KnightMurloc
approved these changes
Feb 7, 2025
KnightMurloc
pushed a commit
that referenced
this pull request
Aug 28, 2025
Previously --set only applied filtering to backup verification. This patch also implements it for WAL file verification, only checking the files required by the backup. If backup manifest is unreadable, no WAL files are checked. Ticket: ADBM-2033 (cherry picked from commit b4c707b)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 1, 2025
Previously --set only applied filtering to backup verification. This patch also implements it for WAL file verification, only checking the files required by the backup. If backup manifest is unreadable, no WAL files are checked. Ticket: ADBM-2033 (cherry picked from commit b4c707b)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 5, 2025
Previously --set only applied filtering to backup verification. This patch also implements it for WAL file verification, only checking the files required by the backup. If backup manifest is unreadable, no WAL files are checked. Ticket: ADBM-2033 (cherry picked from commit b4c707b)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 15, 2025
Previously --set only applied filtering to backup verification. This patch also implements it for WAL file verification, only checking the files required by the backup. If backup manifest is unreadable, no WAL files are checked. Ticket: ADBM-2033 (cherry picked from commit b4c707b)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 16, 2025
Previously --set only applied filtering to backup verification. This patch also implements it for WAL file verification, only checking the files required by the backup. If backup manifest is unreadable, no WAL files are checked. Ticket: ADBM-2033 (cherry picked from commit b4c707b)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 18, 2025
Previously --set only applied filtering to backup verification. This patch also implements it for WAL file verification, only checking the files required by the backup. If backup manifest is unreadable, no WAL files are checked. Ticket: ADBM-2033 (cherry picked from commit b4c707b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --set filtering for archive verification
Previously --set only applied filtering to backup verification. This patch
also implements it for WAL file verification, only checking the files required
by the backup. If backup manifest is unreadable, no WAL files are checked.