Fix replacing of filtered WAL record with no-op #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPDB does not expect backup blocks in records whose resource manager is XLOG, so the https://github.com/arenadata/gpdb/blob/1b44caf6b58a8d60e4b0630a44d1c031cf739eae/src/backend/access/transam/xlog.c#L10439 assert was triggered in the case when a record with backup blocks was filtered out. If the initial record has backup blocks, clear their flags in the xl_info field and increase xl_len to treat the backup blocks as a resource manager specific data. The contents of resource manager specific data does not matter if the record is no-op.
KnightMurloc
approved these changes
Feb 27, 2025
bandetto
approved these changes
Feb 28, 2025
KnightMurloc
pushed a commit
that referenced
this pull request
Aug 28, 2025
GPDB does not expect backup blocks in records whose resource manager is XLOG, so the https://github.com/arenadata/gpdb/blob/1b44caf6b58a8d60e4b0630a44d1c031cf739eae/src/backend/access/transam/xlog.c#L10439 assert was triggered in the case when a record with backup blocks was filtered out. If the initial record has backup blocks, clear their flags in the xl_info field and increase xl_len to treat the backup blocks as a resource manager specific data. The contents of resource manager specific data does not matter if the record is no-op. Ticket: ADBM-2135 (cherry picked from commit 011094a)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 1, 2025
GPDB does not expect backup blocks in records whose resource manager is XLOG, so the https://github.com/arenadata/gpdb/blob/1b44caf6b58a8d60e4b0630a44d1c031cf739eae/src/backend/access/transam/xlog.c#L10439 assert was triggered in the case when a record with backup blocks was filtered out. If the initial record has backup blocks, clear their flags in the xl_info field and increase xl_len to treat the backup blocks as a resource manager specific data. The contents of resource manager specific data does not matter if the record is no-op. Ticket: ADBM-2135 (cherry picked from commit 011094a)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 5, 2025
GPDB does not expect backup blocks in records whose resource manager is XLOG, so the https://github.com/arenadata/gpdb/blob/1b44caf6b58a8d60e4b0630a44d1c031cf739eae/src/backend/access/transam/xlog.c#L10439 assert was triggered in the case when a record with backup blocks was filtered out. If the initial record has backup blocks, clear their flags in the xl_info field and increase xl_len to treat the backup blocks as a resource manager specific data. The contents of resource manager specific data does not matter if the record is no-op. Ticket: ADBM-2135 (cherry picked from commit 011094a)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 15, 2025
GPDB does not expect backup blocks in records whose resource manager is XLOG, so the https://github.com/arenadata/gpdb/blob/1b44caf6b58a8d60e4b0630a44d1c031cf739eae/src/backend/access/transam/xlog.c#L10439 assert was triggered in the case when a record with backup blocks was filtered out. If the initial record has backup blocks, clear their flags in the xl_info field and increase xl_len to treat the backup blocks as a resource manager specific data. The contents of resource manager specific data does not matter if the record is no-op. Ticket: ADBM-2135 (cherry picked from commit 011094a)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 16, 2025
GPDB does not expect backup blocks in records whose resource manager is XLOG, so the https://github.com/arenadata/gpdb/blob/1b44caf6b58a8d60e4b0630a44d1c031cf739eae/src/backend/access/transam/xlog.c#L10439 assert was triggered in the case when a record with backup blocks was filtered out. If the initial record has backup blocks, clear their flags in the xl_info field and increase xl_len to treat the backup blocks as a resource manager specific data. The contents of resource manager specific data does not matter if the record is no-op. Ticket: ADBM-2135 (cherry picked from commit 011094a)
KnightMurloc
pushed a commit
that referenced
this pull request
Sep 18, 2025
GPDB does not expect backup blocks in records whose resource manager is XLOG, so the https://github.com/arenadata/gpdb/blob/1b44caf6b58a8d60e4b0630a44d1c031cf739eae/src/backend/access/transam/xlog.c#L10439 assert was triggered in the case when a record with backup blocks was filtered out. If the initial record has backup blocks, clear their flags in the xl_info field and increase xl_len to treat the backup blocks as a resource manager specific data. The contents of resource manager specific data does not matter if the record is no-op. Ticket: ADBM-2135 (cherry picked from commit 011094a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix replacing of filtered WAL record with no-op
GPDB does not expect backup blocks in records whose resource manager is XLOG, so
the https://github.com/arenadata/gpdb/blob/1b44caf6b58a8d60e4b0630a44d1c031cf739eae/src/backend/access/transam/xlog.c#L10439
assert was triggered in the case when a record with backup blocks was filtered
out.
If the initial record has backup blocks, clear their flags in the xl_info field
and increase xl_len to treat the backup blocks as a resource manager specific
data. The contents of resource manager specific data does not matter if the
record is no-op.