forked from pgbackrest/pgbackrest
-
Notifications
You must be signed in to change notification settings - Fork 3
ADBM-2436: Fix WAL filtering when the checksum is in the next segment file #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed.
red1452
reviewed
Jul 23, 2025
red1452
approved these changes
Jul 23, 2025
silent-observer
approved these changes
Jul 23, 2025
KnightMurloc
added a commit
that referenced
this pull request
Aug 28, 2025
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed. Ticket: ADBM-2436 (cherry picked from commit cfcf088)
KnightMurloc
added a commit
that referenced
this pull request
Aug 29, 2025
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed. Ticket: ADBM-2436 (cherry picked from commit cfcf088)
KnightMurloc
added a commit
that referenced
this pull request
Aug 29, 2025
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed. Ticket: ADBM-2436 (cherry picked from commit cfcf088)
KnightMurloc
added a commit
that referenced
this pull request
Sep 1, 2025
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed. Ticket: ADBM-2436 (cherry picked from commit cfcf088)
KnightMurloc
added a commit
that referenced
this pull request
Sep 1, 2025
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed. Ticket: ADBM-2436 (cherry picked from commit cfcf088)
KnightMurloc
added a commit
that referenced
this pull request
Sep 5, 2025
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed. Ticket: ADBM-2436 (cherry picked from commit cfcf088)
KnightMurloc
added a commit
that referenced
this pull request
Sep 15, 2025
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed. Ticket: ADBM-2436 (cherry picked from commit cfcf088)
KnightMurloc
added a commit
that referenced
this pull request
Sep 16, 2025
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed. Ticket: ADBM-2436 (cherry picked from commit cfcf088)
KnightMurloc
added a commit
that referenced
this pull request
Sep 18, 2025
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one file, and the checksum is in the other. Then, when processing the first file, xl_info and xl_rmid could have been changed, but not the checksum, since it is in another file. When processing the next file, the checksum would also not have been changed since xl_info and xl_rmid are in the previous file. This led to the fact that we could get a recovery error stating that the checksum did not converge. Fix this by reading and processing records from previous and next files, regardless of which part of the records divided into 2 files is in the current file. These changes also revealed a number of errors in the tests related to incorrect filling of the xlp_rem_len header field. These errors have also been fixed. Ticket: ADBM-2436 (cherry picked from commit cfcf088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the WAL record is divided into 2 files, both xl_info and xl_rmid are in one
file, and the checksum is in the other. Then, when processing the first file,
xl_info and xl_rmid could have been changed, but not the checksum, since it is
in another file. When processing the next file, the checksum would also not have
been changed since xl_info and xl_rmid are in the previous file. This led to the
fact that we could get a recovery error stating that the checksum did not
converge.
Fix this by reading and processing records from previous and next files,
regardless of which part of the records divided into 2 files is in the current
file.
These changes also revealed a number of errors in the tests related to incorrect
filling of the xlp_rem_len header field. These errors have also been fixed.