Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

bytecurl
Copy link
Contributor

@bytecurl bytecurl commented Apr 7, 2022

Added OS specific local files .DS_Store (macOS) and Thumbs.db (Windows) that often sneak their way in when not explicitly included in the .gitignore file

cameel
cameel previously approved these changes Apr 7, 2022
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cameel cameel enabled auto-merge April 7, 2022 18:22
@cameel cameel disabled auto-merge April 7, 2022 18:22
@cameel
Copy link
Collaborator

cameel commented Apr 7, 2022

Ah, wait. There are some weird merge commits in your branch. Can you rebase on develop and squash them?

A more concrete commit description would also be nice - i.e. in what specifically got changed about .gitignore. Only saying that it updates .gitignore is a bit useless because that's obvious from the file list.

@cameel cameel changed the title Update .gitignore Add .DS_Store and Thumbs.db to .gitignore Apr 7, 2022
@cameel cameel dismissed their stale review April 7, 2022 18:25

Needs squshing and description tweak.

Add OS specific local files that should not be included in a git repository - .DS_Store (macOS) and Thumbs.db (Windows)
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and updated commit description.

@cameel cameel enabled auto-merge April 8, 2022 18:25
@cameel cameel merged commit 4e1de37 into argotorg:develop Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants