Fix validation error causing ICE with isoltest --test #13167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you put the rename in a separate commit? And one rebase to fix the conflicts and then this should be good to go |
Contributor
Author
|
I made the changes you've asked. Please let me know if I messed up something :) |
Contributor
|
Looks good to me. The CI failures are unrelated to your changes (some network problem). I restarted the CI tests, maybe that'll fix them. |
Contributor
Author
|
Okay, now I should wait for a review? |
Marenz
approved these changes
Jun 22, 2022
Contributor
|
I just forgot to click the review button ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #13070
Add a
catchto handle the exception.Rename
boostTest.cpptosoltest.cpp& EditCMakeLists.txtaccordingly to make sure it builds properly